Skip to content

feat(db): add database migration command #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2025
Merged

feat(db): add database migration command #274

merged 2 commits into from
Sep 15, 2025

Conversation

@kayra1
Copy link
Contributor

@kayra1 kayra1 commented Sep 5, 2025

Description

This change introduces goose to Notary, which manages the database migrations. It also introduces some wrapper commands: notary migrate up, notary migrate down and notary migrate status. If a version number is given, up will migrate up to the version number and down will migrate down to the version number. If it wasn't given, down will go down one version, and up will go up to the latest version.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 changed the title add migrations to DB feat(db): add database migration command Sep 5, 2025
@kayra1 kayra1 force-pushed the goose branch 9 times, most recently from 442f1fa to 90369be Compare September 10, 2025 22:18
@kayra1 kayra1 marked this pull request as ready for review September 11, 2025 06:13
@kayra1 kayra1 requested a review from a team as a code owner September 11, 2025 06:13
saltiyazan
saltiyazan approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@saltiyazan saltiyazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Goose, I tried to do my best reviewing this. Great work except for a couple of minor questions.
Have you tested the schema locally?

@kayra1
Copy link
Contributor Author

kayra1 commented Sep 15, 2025

Have you tested the schema locally?

I did test it locally, and the rock test actually posts a certificate successfully so we know for a fact that the migration works.

@kayra1 kayra1 requested a review from saltiyazan September 15, 2025 09:43
@kayra1 kayra1 merged commit c273458 into main Sep 15, 2025
19 checks passed
@kayra1 kayra1 deleted the goose branch September 15, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saltiyazan saltiyazan Awaiting requested review from saltiyazan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kayra1 @saltiyazan